-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: floating uninstall button #18047
fix: floating uninstall button #18047
Conversation
@raquelmsmith can you help with the merging of this PR, if you like the changes? |
@neilkakkar not sure if you can help me assign a reviewer. I also want to ask, it there a process for asking for review in this repo. |
this should get thorough front-end review before it is merged as we have lots of buttons all over the place. |
Alright sure, maybe we need a secondary testing organization like Applause, to speed this up. |
Meanwhile I will take a look at something else. Thanks @raquelmsmith |
we have lots of visual regression tests so I'm not that concerned, just want to take a manual poke around to be extra sure :) will do that on monday! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this!
This is not the fix though. We need position: relative
on .LemonButton
e.g. for position of actions in LemonButtonWithSideAction
. This also doesn't seem to actually fix the issue.
The real fix is removing the .Plugins__Popconfirm
class, which has a problematic z-index
that we no longer need.
Hmm, I believe something went wrong when rebasing/merging, because there are many commits considered part of the diff, which already are in |
6cbc858
to
95060d6
Compare
This PR is messed up, I'll close it out and open another one |
95060d6
to
46c0750
Compare
Problem
#18029
Changes
How did you test this code?
In the browser
Browse Apps
>Apps Management