Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(surveys): add surveys opt in to onboarding ingestion #18045

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Oct 17, 2023

Problem

Add surveys snippet to onboarding ingestion so we can have it default on

Changes

Screen Shot 2023-10-17 at 2 12 21 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@raquelmsmith
Copy link
Member

Interesting, why does surveys have to be opted in to?

@liyiy
Copy link
Contributor Author

liyiy commented Oct 18, 2023

Interesting, why does surveys have to be opted in to?

This is a good summary for it! https://posthog.slack.com/archives/C034XD440RK/p1697434622931679

basically: we want to be explicit to the new user about surveys being turned on for them. It's a similar setting to the opt_in_site_apps setting we previously had

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It unnecessarily increases the package size for teams that don't use surveys. We only load all the js if they opt in.

So, I wonder if it's worth saying this more explicitly in onboarding? The only big reason tbh not to have it hidden + default on. But we don't say the same for session recordings here, which seems to work fine + those who care come back to turn it off, so LGTM!

@liyiy liyiy merged commit 0546442 into master Oct 18, 2023
74 checks passed
@liyiy liyiy deleted the surveys-snippet-onboarding branch October 18, 2023 15:17
Justicea83 pushed a commit to Justicea83/posthog that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants