feat: add and handle never drop data field #17978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelmsmith
changed the title
daibhin
pushed a commit
that referenced
this pull request
Oct 23, 2023
* add and handle never drop data field * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17365 was doing weird things with migrations (because we are trying to do weird things with migrations) so I'm breaking it up into two: this PR with the basic functionality, then the next with the email changes.
Problem
See: https://posthog.slack.com/archives/C043VJ93L3B/p1694100638757679
It would be nice if for larger customers we made sure that their data was never dropped.
Changes
Adds a field to the organization model never_drop_data. This field retrieved from the customer's billing response (added in https://github.com/PostHog/billing/pull/358). If true, then we never quota limit the org.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Added a test.
This code was reviewed in #17365 so I'm gonna skip reviews.