feat(surveys): Multiple Choice question results #17954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jurajmajerik
commented
Oct 12, 2023
jurajmajerik
commented
- Implemented Multiple Choice question visualization
- Adjusted bar charts as suggested by @corywatilo
neilkakkar
reviewed
Oct 12, 2023
| @@ -207,6 +207,7 @@ export interface LineGraphProps { | |||
| showPersonsModal?: boolean | |||
| tooltip?: TooltipConfig | |||
| inCardView?: boolean | |||
| inSurveyView?: boolean | |||
There was a problem hiding this comment.
These are nicer as specific customisation options, like hideGrid and hideAxis
There was a problem hiding this comment.
clearer to understand, and then not limited to just surveys for whoever uses this component in the future
There was a problem hiding this comment.
I agree and added hideXAxis and hideYAxis props.
I still had to leave inSurveyView in two places - the logic in the component is convoluted and could use a refactor - but not sure if it's worth it at this point since Cory mentioned he's planning to rethink our visualization components.
liyiy
reviewed
Oct 12, 2023
|
The empty state here just has this box. This is also the same for single choice results too, can we double check this? 😮 
|
liyiy
approved these changes
Oct 12, 2023
…hub.com/PostHog/posthog into surveys/multiplechoice-question-results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.