fix: Performance issue with player logs #17948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
commented
Oct 12, 2023
frontend/src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts
Outdated
Show resolved
Hide resolved
pauldambra
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
git checkout origin/master -- frontend/src/scenes/notebooks/NotebookSelectButton/NotebookSelectButton.tsx is what I use to remove files from PRs when they sneak in
There was a problem hiding this comment.
git checkout origin/master -- frontend/src/scenes/notebooks/Notebook/SlashCommands.tsx is what I use to remove files from PRs when they sneak in
There was a problem hiding this comment.
Oh sweet. I will endeavour to do that next time 🙈
There was a problem hiding this comment.
I will never forgive you (it's sad, but we have to maintain standards)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Long bit of debugging led me to find out something frustrating - the logging from the replayer is the source of a huge number of lock ups. Essentially the logged object can be so massive and full of getter proxies that simply serializing it takes such a long time that the browser locks up.
Any recording with a lot of warnings suffered from this which is largely why some people had such bad experiences.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?