Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want the ability to enable/disable optimisations in HogQL as needed, including specifying them on the client side to shorten the feedback loop.
Changes
HogQLQueryModifiers
interface that can be appended to aHogQLQuery
node to specify the behaviour of query features.modifiers.py
->create_default_modifiers_for_team
for setting modifiers automaticallypersonsOnEventsMode
to the modifiers (camelCased python? 🤔 🤷)/debug
endpointNext steps
How did you test this code?
Wrote tests. In the future all modifiers should get their own tests under
test_modifiers.py