Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update wait-on-action #17945

Merged
merged 1 commit into from
Oct 12, 2023
Merged

chore: update wait-on-action #17945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ jobs:
- name: Wait for PostHog
# these are required checks so, we can't skip entire sections
if: needs.changes.outputs.shouldTriggerCypress == 'true'
uses: iFaxity/wait-on-action@v1
# this action might be abandoned - but v1 doesn't point to latest of v1 (which it should)
# so pointing to v1.1.0 to remove warnings about node version with v1
# todo check https://github.com/iFaxity/wait-on-action/releases for new releases
uses: iFaxity/[email protected]
timeout-minutes: 3
with:
verbose: true
Expand Down
2 changes: 0 additions & 2 deletions cypress/support/e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ afterEach(function () {
const event = state === 'passed' ? 'e2e_testing_test_passed' : 'e2e_testing_test_failed'

if (E2E_TESTING) {
cy.log(`E2E_TESTING: ${event} ${Cypress.spec.name}`, { state, duration })
cy.window().then((win) => {
cy.log('has posthog on window', { window, posthog: (win as any).posthog })
;(win as any).posthog?.capture(event, { state, duration })
})
}
Expand Down