chore(plugin-server): remove INGESTION_DELAY_WRITE_ACKS and workerMethods

[bretthoerner]

Problem

INGESTION_DELAY_WRITE_ACKS=true has been rolled out.

Changes

Cleanup.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

[bretthoerner]

I'm worried that the tests depend on the false behavior. I'll look at this later.

[xvello]

Thanks for cleaning this up!

I think that the failures are related to the DLQ handling, that was committed just after INGESTION_DELAY_WRITE_ACKS:

• The consumer handles messages just less than 1MB gracefully test name is wrong: we're actually creating a message over 1MB, that fails on the ACK wait
• To handle that, we need to add a .catch to the promises returned by eachMessage
• To my knowledge, the only non-retriable kafka error we'd get at this point is "message too big", and sending these to DLQ won't help, as the DLQ topic has the same size as the output topic. We should send an ingestion warning instead
• While we're here, it's worth auditing this handling code to make sure it does make proper sense, and that the DLQ write errors are properly handled

[xvello]

Looking good!

[bretthoerner]

Yup @xvello, tests immediately pass when rebased ontop of #17893

😰 😰 😰