feat(surveys): Add cypress e2e tests

[neilkakkar]

Problem

~~Will go in after Eli's change: #17902 ~~

Changed my mind, these should be stable enough to work with/without the changes, and should help us catch issues. Happy to fix any tests that break with follow up changes.

But wanted to hit the ball running with e2e tests since things should be relatively stable after the overhaul

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[jurajmajerik]

Nice! How broad do we generally want to be with these? Seems we could test even more things here, but ofc it's a tradeoff.

[neilkakkar]

indeed, generally I don't want to test the UI looks perfectly correct, since the snapshots should take care of that. It's more about the functionality: clicking buttons works, and does the things you'd expect.

But at the same time, don't want to get too deep into clicking every button in a drop down, that's just overkill, and don't want things to get annoying where every small change requires a cypress test update.

I will write a few more when the UI polish is done, but this seemed like a reasonable basic functionality loop, which covers critical parts like when you add some targeting, it should stick around when you launch 🙈 (yes this was an old bug)