fix(dev): do not sync the cloud announcement flag #17911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
approved these changes
Oct 11, 2023
| @@ -36,7 +36,10 @@ def handle(self, *args, **options): | |||
| deleted_flags = FeatureFlag.objects.filter(team=team, deleted=True).values_list("key", flat=True) | |||
| for flag in flags.keys(): | |||
| flag_type = flags[flag] | |||
| if flag in deleted_flags: | |||
| # do not sync the cloud announcement flag for in-app banners | |||
| if flag == "cloud-announcement": | |||
There was a problem hiding this comment.
but, but, what if I want to test the banner Thomas?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running
DEBUG=1 python3 manage.py sync_feature_flagsadds the in-app banner with the latest message.Changes
This PR excludes the
cloud-announcementflag from the sync comman.How did you test this code?
Deleted the flag and ran the command