chore(decide): Add missing span instrumentation #17910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajmajerik
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our spans are missing some information of what happens between the request to get cohorts, and the request to get feature flags.
During spikes, we're losing upto 2s in between, which is insane. See: https://posthog.sentry.io/performance/posthog:948a2386c4124c8bb2433cf859a1b510/?breakdown=none&project=1899813&query=&showTransactions=p100&sort=-transaction.duration&statsPeriod=14d&transaction=%2Fdecide%2F%5B%23%5D.%2A
This helps us figure out if it has anything to do with feature flag parsing. I'd be surprised if it does, but lets see 👀
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Run locally, see span in sentry