Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): edit SQL directly where possible #17905

Merged
merged 11 commits into from
Oct 16, 2023
Merged

feat(hogql): edit SQL directly where possible #17905

merged 11 commits into from
Oct 16, 2023

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Oct 11, 2023

Problem

We want to offer our users the option of directly editing the SQL query behind most of our interface elements. This to give them more flexibility in asking for data (don't like funnels? edit and go), and to allow them to verify how the data is gathered (offloading support work).

Changes

  • Adds a "Edit SQL directly" button next to the "Open as a new insight" button for the "event explorer" and (feature flagged) persons pages.
  • Change the icons for both buttons to better match.

2023-10-11 09 53 00

How did you test this code?

Clicked on the SQL buttons

Out of scope

  • Adding this to other insights. This will come once we convert them to HogQL.
  • An option to go back to the old view with a modified query.
  • Pretty printing

Questions

  • Worth it? Too confusing? Design suggestions?

@mariusandra mariusandra changed the base branch from master to events-query-runner October 11, 2023 08:20
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving the "open as insight" / "edit as sql" buttons into the export menu? Getting a bit crowded there and the interface jumps when first loading the event explorer.

Base automatically changed from events-query-runner to master October 11, 2023 14:58
@mariusandra
Copy link
Collaborator Author

Something like this?

2023-10-13 18 08 55

@thmsobrmlr
Copy link
Contributor

Yup, that looks great

@mariusandra mariusandra merged commit 23fec44 into master Oct 16, 2023
73 checks passed
@mariusandra mariusandra deleted the hogql-button branch October 16, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants