feat(surveys): templates #17904
feat(surveys): templates #17904
Conversation
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: Joe Martin <[email protected]>
…into surveys/templates
|
Screenshots with updated suggestions from @corywatilo 
|
|
I'm not releasing this behind a feature flag (unless there's a very good reason to), so I would appreciate a thorough click through review if possible 🙏 😁 |
|
I'd drop the (Superhuman) on the product-market fit survey. AS Cory said, many people won't understand the reference, plus Superhuman didn't actually create the survey. |
There was a problem hiding this comment.
Overall looks great!
Some issues:
-
Once I create a new survey with template, I can't create a 2nd one using a template.
-
There's something weird happening sporadically, when if I create a survey, and then go to create a new one, click on any template, I'm redirected to the survey I just created.
-
The link button says 'Submit' (which goes to Calendly) which isn't very clear. Should call it register
| @@ -39,6 +39,7 @@ export const appScenes: Record<Scene, () => any> = { | |||
| [Scene.EarlyAccessFeature]: () => import('./early-access-features/EarlyAccessFeature'), | |||
| [Scene.Surveys]: () => import('./surveys/Surveys'), | |||
| [Scene.Survey]: () => import('./surveys/Survey'), | |||
| [Scene.SurveyTemplates]: () => import('./surveys/SurveyTemplates'), | |||
There was a problem hiding this comment.
the new scene for templates doesn't really make sense anymore, since it's on the surveys page itself?
There was a problem hiding this comment.
It actually still routes to survey_templates which is its own scene, I was thinking a bit about this on whether to just incorporate it directly onto the surveys components or not but I think a separation of routes is the better option. That way users can always be directed to the templates page instead of it being a "state"
Co-authored-by: Joe Martin <[email protected]>
Co-authored-by: Neil Kakkar <[email protected]>
…into surveys/templates
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
From the latest preview above, the title and description now feel very far apart now that they're shorter. I'd move one of them so they're displayed together. |
agreed! done |
* routes for survey templates * basic on click setup logic * Update UI snapshots for `chromium` (2) * import type * Apply suggestions from code review Co-authored-by: Joe Martin <[email protected]> * address feedback from cory * fix logic * remove unused logic file * Update frontend/src/scenes/surveys/constants.tsx Co-authored-by: Joe Martin <[email protected]> * Update frontend/src/scenes/surveys/constants.tsx Co-authored-by: Neil Kakkar <[email protected]> * address comments * Update UI snapshots for `chromium` (2) * more fixes * Update UI snapshots for `webkit` (2) * Update UI snapshots for `webkit` (2) * Update UI snapshots for `chromium` (2) * move description and title together * fix e2e --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Joe Martin <[email protected]> Co-authored-by: Neil Kakkar <[email protected]>
Problem
Build some pre defined survey templates
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?