Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set keepalive to 60 on gunicorn #17897

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Oct 10, 2023

Problem

The default is 2 seconds, the default for ALBs is 30 seconds

This can cause a race condition where gunicorn closes the connection as the ALB sends a request, resulting in a 502.
image

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

The default is 2 seconds, the default for ALBs is 30 seconds

This can cause a race condition where gunicorn closes the connection
as the ALB sends a request, resulting in a 502.
@frankh frankh requested review from xvello and ellie October 10, 2023 16:18
@frankh frankh changed the title Set keepalive to 60 on gunicorn chore: Set keepalive to 60 on gunicorn Oct 10, 2023
@frankh frankh changed the title chore: Set keepalive to 60 on gunicorn feat: Set keepalive to 60 on gunicorn Oct 10, 2023
@frankh frankh merged commit 7a14421 into master Oct 11, 2023
72 of 74 checks passed
@frankh frankh deleted the frank/keepalive-gunicorn branch October 11, 2023 07:54
daibhin pushed a commit that referenced this pull request Oct 23, 2023
Set keepalive to 60 on gunicorn

The default is 2 seconds, the default for ALBs is 30 seconds

This can cause a race condition where gunicorn closes the connection
as the ALB sends a request, resulting in a 502.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants