chore(plugins-server): remove eachBatchLegacyIngestion #17894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/retire-ingestionkafkajs
branch
from
2e1a771 to
938bb93
Compare
xvello
changed the title
xvello
force-pushed
the
xvello/retire-ingestionkafkajs
branch
from
938bb93 to
ce6db75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Prod has been running rdkafka since October 4th, we should cleanup the dead code calling kafkajs
Changes
KAFKA_CONSUMPTION_USE_RDKAFKAenvvar and theeachBatchLegacyIngestionloop used by analytics ingestion when it's set to falseKAFKA_CONSUMPTION_USE_RDKAFKAfrom the functional test matrixThere are still other kafkajs consumers in the monolith (jobs, scheduler, onevent, webhooks), that will be need to be migrated away before we delete
KafkaJSIngestionConsumerHow did you test this code?