Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove title expand toggle #17887

Merged
merged 2 commits into from
Oct 11, 2023
Merged

chore: remove title expand toggle #17887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1313c76
chore: remove title expand toggle
daibhin Oct 10, 2023
8182131
remove cursor pointer
daibhin Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/scenes/notebooks/Nodes/NodeWrapper.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
display: flex;
justify-content: space-between;
align-items: center;
font-size: 0.75rem;
font-weight: 700;
color: var(--muted-alt-3000);
font-size: 0.875rem;
font-weight: 500;
color: var(--primary-alt);
padding: var(--notebook-node-meta-padding);
border-bottom: 1px solid var(--border);
height: var(--notebook-node-meta-height);
Expand Down
19 changes: 6 additions & 13 deletions frontend/src/scenes/notebooks/Nodes/NodeWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,19 +154,12 @@ function NodeWrapper<T extends CustomNotebookNodeAttributes>({
) : (
<>
<div className="NotebookNode__meta" data-drag-handle>
<LemonButton
onClick={() => setExpanded(!expanded)}
size="small"
status="primary-alt"
className="flex-1"
icon={
isEditable ? (
<IconDragHandle className="cursor-move text-base shrink-0" />
) : undefined
}
>
<span className="flex-1 cursor-pointer">{title}</span>
</LemonButton>
<div className="flex items-center gap-1">
{isEditable && (
<IconDragHandle className="cursor-move text-base shrink-0" />
)}
<span>{title}</span>
</div>

<div className="flex space-x-1">
{parsedHref && (
Expand Down