feat(3000): Added link specific styles #17867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
changed the title
benjackwhite
requested review from
a team
and removed request for
thmsobrmlr,
Twixes and
daibhin
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
daibhin
approved these changes
Oct 9, 2023
|
Why not use this lighter blue as the primary color (including buttons) in 3000 dark mode? |
Certainly could do. I actually found the light button to be almost too light as a button but then too dark as a link 😅 I'd be happy to also move to changing the buttons as well and just make the light color the new primary. @corywatilo thoughts? |
|
Hmm, yeah, it's going to be tricky. Let's try this for now. |
# Conflicts: # frontend/src/scenes/session-recordings/playlist/SessionRecordingPreview.tsx # frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistItem.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Links in 3000 dark mode are just too dark...
Step 1: Give them all their own styles, so we can try a different color (I picked Github dark mode blue to start with)
I have no string opinion about the current dark mode link colors, other than it needs to change :D so consider this the piping needed for us to make the change
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?