Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(invites): Clarify expiration message #17862

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Oct 9, 2023

Changes

Resolves #17793 by changing the message to just "Invite expired".

@Twixes Twixes requested a review from liyiy October 9, 2023 12:43
Copy link
Contributor

@liyiy liyiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think it's slightly more clear to tell the user they have to delete and recreate the invite than just saying it's expired but I don't think it's a pressing issue either way

@Twixes
Copy link
Member Author

Twixes commented Oct 10, 2023

Good point, changed to "Expired – please recreate", which should be clear without looking like a button

@Twixes Twixes enabled auto-merge (squash) October 10, 2023 14:15
@Twixes Twixes merged commit eb8071c into master Oct 10, 2023
70 of 72 checks passed
@Twixes Twixes deleted the clarify-invite-expiration branch October 10, 2023 14:36
daibhin pushed a commit that referenced this pull request Oct 23, 2023
* chore(invites): Clarify expiration message

* Change wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expired invite link isn't actionable?
2 participants