fix(batch-exports): Include properties in feature_enabled call #17860
Conversation
| @@ -170,11 +170,20 @@ def create(self, validated_data: dict) -> BatchExport: | |||
| destination_data = validated_data.pop("destination") | |||
| team_id = self.context["team_id"] | |||
|
|
|||
| if validated_data["interval"] not in ("hour", "day", "week") and not posthoganalytics.feature_enabled( | |||
| "high-frequency-batch-exports", | |||
There was a problem hiding this comment.
hey @tomasfarias you can try this locally to check if it works or not. (just create the same feature flag in your local env with the same match by and check if it works)
In this case, the feature flag is based on the project group, and not distinct IDs, which means you need to pass in the groups parameter with key project and value as the project ID.
So, you just need to add project instead of organization in this case, and the property 'id' in group_properties
There was a problem hiding this comment.
One potential gotcha, and reason not to use project and use organisations instead is that currently this will enable it for both, team 2 and 9291 in EU and US both, vs. just those teams in US.
Hence, using org IDs, which are unique across deployments works better usually.
There was a problem hiding this comment.
We can switch the flag to organizations. That means the code changes implemented here are enough, right? Thank you for your input!
There was a problem hiding this comment.
I've tested things out locally using this branch and flags based on organization and things work 👍 (Discovered a frontend bug while I was at it).
Problem
The backend is returning a 403, even though the flag is enabled for a specific team. Maybe the call is missing properties used in other similar calls?
Changes
Adds arguments to
feature_enabledcall when creating high frequency batch exports.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?