feat: onboarding, remove product intro, fix navigation #17858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test is unrelated and failing on other PRs so ignoring. |
daibhin
pushed a commit
that referenced
this pull request
Oct 23, 2023
* move onstart to products page * remove product intro * include stepkey as prop * redo how navigation works * go back to products if first step * fix url redirect loop * fix jitteryness with otherproductsstep * fix grumpy linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The product intro pages were causing a 20% drop in conversion to the next step. Also navigation was inconsistent and URLs did't contain the correct step keys because component names are minified on build 🙃
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
🐭 💻 👀