Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-analytics): Fix top pages sql and add some extra insights #17850

Merged
merged 6 commits into from
Oct 9, 2023
Merged

feat(web-analytics): Fix top pages sql and add some extra insights #17850

merged 6 commits into from
Oct 9, 2023

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Oct 6, 2023 •
edited
Loading

Problem

More web analytics!

Changes

Apologies for the 2-for-1-special.

  • Found a flaw in my SQL, split out scroll depth into a separate CTE from pathname. Now pathname doesn't undercount, previously it did not count the first $pageview of a visit, as it did not have a previous pathname
  • Added some other insights to the dashboard.
Screenshot 2023-10-06 at 16 03 27

Not solved yet:

  • The UI for the tables is a bit janky
  • The world map has a load more button which I'd like to hide

How did you test this code?

(Behind FF) Ran it locally

@robbie-c robbie-c changed the title feat(web-analytics): Fix top pages sql feat(web-analytics): Fix top pages sql and add some extra insights Oct 6, 2023
@robbie-c robbie-c marked this pull request as ready for review October 9, 2023 09:41
@robbie-c robbie-c requested a review from mariusandra October 9, 2023 11:00
@robbie-c robbie-c merged commit aade1e4 into master Oct 9, 2023
81 checks passed
@robbie-c robbie-c deleted the fix-top-pages-sql branch October 9, 2023 11:09
daibhin pushed a commit that referenced this pull request Oct 23, 2023
@robbie-c @daibhin
feat(web-analytics): Fix top pages sql and add some extra insights (#…
ada936a 
…17850)

* Fix top pages SQL

* Use person id for now

* Add limits to web analytics queries

* Add some trends to web analytics

* Tweak query date ranges and formatting

* Consistently use person_id for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbie-c @mariusandra