-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: account for negative timestamps from rrweb #17849
Conversation
Hey @daibhin! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on how we could level up the validation even more but not blocking since this is better already
@pauldambra I didn't exactly know how to do it but another quick win would be to catch any invalid parameter and send it to Sentry. Debugging via logs / Kafka messages is always needle in a haystack kind of work |
We increasingly use the contents of rrweb events during ingestion so we need stricter validation...
We recently saw an issue caused by having received rrweb events from a client that had negative timestamps 🙃
This change ensures that timestamps we lift from rrweb events to create replay events are positive and result in a valid luxon datetime