fix: Segmenter issue leading to paused playback #17840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
commented
Oct 6, 2023
benjackwhite
commented
Oct 6, 2023
frontend/src/scenes/session-recordings/player/utils/segmenter.ts
Outdated
Show resolved
Hide resolved
daibhin
approved these changes
Oct 6, 2023
frontend/src/scenes/session-recordings/player/utils/segmenter.ts
Outdated
Show resolved
Hide resolved
benjackwhite
commented
Oct 6, 2023
frontend/src/scenes/session-recordings/player/utils/segmenter.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The playback of replays syncs the rrweb time with our own tracking and it could happen that a timestamp was in between the end and start time of two ajoining segments.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Updated tests and validated it myself