fix(queries): standardise on "results" over "result" #17798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
reviewed
Oct 5, 2023
|
Thanks! I'm likely going to merge this into my PersonsQuery PR, as the pydantic validation errors about result vs results in the QueryResponse was what triggered this PR. |
thmsobrmlr
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Found one place where we need to adapt the logic https://github.com/PostHog/posthog/blob/master/frontend/src/queries/nodes/DataNode/dataNodeLogic.ts#L69. Caching and all other places I though of look fine 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some query nodes return their results as
result, some asresults.Changes
Standardises all on
results, as this is what the currently publicly exposedEventsQueryandHogQLQueryuse.Also, we almost always have more than one "result", so plural makes sense to me.
How did you test this code?
The HogQL powered lifecycle insight loaded. Both in its cached and refreshed form... though I'm not sure what I don't know about all of this, so 👀 appreciated!