Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove content width toggle from popover #17775

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Oct 4, 2023

Problem

Toggle does nothing in the popover

Changes

Remove the toggle

How did you test this code?

Toggle is gone

@benjackwhite
Copy link
Contributor

Does it do nothing? It still toggles, and if you open the notebook in full screen it still makes a difference 🤔
Maybe we just want to hide it when the sidebar isn't big enough (i.e. not full screen or even better based on its content size?

@daibhin daibhin requested a review from benjackwhite October 5, 2023 13:31
@daibhin daibhin requested a review from benjackwhite October 9, 2023 10:38
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the dangling import 👍

@daibhin daibhin merged commit c6355e9 into master Oct 9, 2023
72 checks passed
@daibhin daibhin deleted the dn-fix/remove-content-width branch October 9, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants