fix(hogql): fix edge cases when converting real world lifecycle filters #17728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
approved these changes
Oct 4, 2023
| @@ -27,17 +28,72 @@ | |||
| from posthog.types import InsightQueryNode | |||
|
|
|||
|
|
|||
| def entity_to_node(entity: BackendEntity) -> EventsNode | ActionsNode: | |||
| def is_property_with_operator(property: Dict): | |||
There was a problem hiding this comment.
Note that the frontend has isPropertyFilterWithOperator, but it works differently
There was a problem hiding this comment.
Good catch! I actually forgot we have something similar on the frontend. Will adapt the naming in the follow up PR, as this got superseded by work in #17813.
|
Superseded by #17813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to make the backend side
filter_to_queryconversion function robust against real-world edge cases.Changes
This PR fixes problems in the conversion for all existing lifecycle filters. The filters were obtained via metabase:
How did you test this code?
Added test examples that were then fixed