Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-analytics): Change query runner query type #17690

Closed
wants to merge 1 commit into from

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Sep 29, 2023

Problem

I wanted the query runner to use the Node type in python as part of #17629

Changes

  • Change the schema.ts -> json -> py so that it exports everything in the file.
  • This meant that I needed to move some types into a different file if they were not convertable. Specifically, I moved QueryContext and QueryContextColumn, as they are not needed outside the front end and include a function type.
  • Change the QueryRunner to use the Node type
  • Changed any python references from schema.Model to schema.QuerySchema, because the root model is no longer useful.

How did you test this code?

Relied on the CI suite

@robbie-c robbie-c force-pushed the change-query-runner-query-type branch from ed01d5b to 2d16ddb Compare September 29, 2023 13:12
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@robbie-c robbie-c closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants