chore: Remove runner abstraction from onEvent #17683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
xvello
reviewed
Oct 6, 2023
tiina303
force-pushed
the
on-event-skip-runner
branch
from
edc0f71 to
90f5e11
Compare
xvello
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Making changes is more complicated due to this abstraction. I can't see us gaining anything from using the worker methods and piscina and runner here.
Note that the webhooks consumer already doesn't use the runner nor piscina (we should just handle this in the batching and what we run in parallel async instead - can't see a reason to use a worker pool)
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?