Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't show "play" overlay when not hovered #17676

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

benjackwhite
Copy link
Contributor

Problem

Sometimes people want to take screenshots of the paused Replay but it is spoiled by the play icon

Changes

  • When paused, only show the play button overlay when hovered.
  • Also fixes the posthog 3000 background color for the player

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@benjackwhite benjackwhite merged commit e5f54a2 into master Sep 28, 2023
72 of 73 checks passed
@benjackwhite benjackwhite deleted the feat/clors branch September 28, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants