fix: celery types and redis queue depth schedule #17672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
approved these changes
Sep 28, 2023
|
|
||
| # PostHog Cloud cron jobs | ||
| # NOTE: We can't use is_cloud here as some Django elements aren't loaded yet. We check in the task execution instead | ||
| # Verify that persons data is in sync every day at 4 AM UTC | ||
| sender.add_periodic_task(crontab(hour=4, minute=0), verify_persons_data_in_sync.s()) | ||
| sender.add_periodic_task(crontab(hour="4", minute="0"), verify_persons_data_in_sync.s()) |
There was a problem hiding this comment.
That is wild that it takes strings 🤔
There was a problem hiding this comment.
I guess cron is strings so they're being very literal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run a celery task once a second to check the redis queue depth. This seems excessive. Let's run it every ten.
Also, cron tab should take strings but we were passing ints