Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Notebook guide #17661

Merged
merged 38 commits into from
Sep 28, 2023
Merged

fix: Update Notebook guide #17661

merged 38 commits into from
Sep 28, 2023

Conversation

benjackwhite
Copy link
Contributor

Problem

  • Updates the guide to be a little more up to date (will do another pass before we release)

Changes

  • Updates the guide to be a little more up to date (will do another pass before we release)
  • Fixes a bug where we assumed every node type had a serialise function

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite changed the base branch from master to feat/notebooks-history September 28, 2023 08:47
@posthog-bot
Copy link
Contributor

Hey @benjackwhite! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@benjackwhite benjackwhite requested review from pauldambra and removed request for Twixes and daibhin September 28, 2023 11:35
Base automatically changed from feat/notebooks-history to master September 28, 2023 12:48
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the joy of stacked PRs 🤣
other than that LGTM

# Conflicts:
#	frontend/src/scenes/notebooks/Notebook/Notebook.scss
#	frontend/src/scenes/notebooks/Notebook/NotebookHistory.tsx
#	frontend/src/scenes/notebooks/Notebook/NotebookSidebar.tsx
#	frontend/src/scenes/notebooks/Notebook/notebookLogic.ts
#	frontend/src/scenes/notebooks/NotebookScene.tsx
@benjackwhite benjackwhite enabled auto-merge (squash) September 28, 2023 13:00
@benjackwhite benjackwhite merged commit e4de9f0 into master Sep 28, 2023
71 checks passed
@benjackwhite benjackwhite deleted the fix/notebook-template branch September 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants