fix(plugin-server): use rdkafka autocommit by storing our own offsets #17657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
approved these changes
Oct 2, 2023
xvello
suggested changes
Oct 2, 2023
bretthoerner
force-pushed
the
brett/store-offsets
branch
from
79dc528 to
cc512bb
Compare
bretthoerner
force-pushed
the
brett/store-offsets
branch
from
cc512bb to
5d2a74e
Compare
xvello
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the rdkafka consumer, we observe a ton of
Broker: Specified group generation id is not validerrors that I believe are a race between our commits and rebalance callbacks.See: https://docs.google.com/document/d/1ysRuQxFlCclXLLay3XBSOMHvWq5fHhqlrkkh9TdWthI/edit#heading=h.qt2rbhy3lwyu
Changes
Rather than doing an async commit ourselves, we store offsets in rdkafka and tell it to autocommit. It promises to do the right thing with respect to rebalances.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Locally, to ensure stored offsets are committed. And CI.