-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Notebooks History #17644
feat: Notebooks History #17644
Conversation
…eat/node-buttons # Conflicts: # frontend/__snapshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png
# Conflicts: # frontend/src/scenes/notebooks/Nodes/NodeWrapper.tsx # frontend/src/scenes/notebooks/Nodes/NotebookNodeFlag.tsx # frontend/src/scenes/notebooks/Nodes/NotebookNodePerson.tsx # frontend/src/scenes/notebooks/Nodes/NotebookNodeSurvey.tsx
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome... a few nitpicks but otherwise 🚢
If there's only a single version and I open the history, then I can click on it and am offered the opportunity to revert. Really the current version shouldn't offer that option
My first instinct to close the history was to repeat the action I'd done to open it...
For 100% score on the PR it'd be awesome if the activity log distinguished between a revert and a not-revert
But that's very finicky of me
frontend/src/scenes/notebooks/Notebook/notebookHistoryLogic.tsx
Outdated
Show resolved
Hide resolved
That's a good point! Modified it to show the "created this" state for the very first activity and mark the "current" version as current so that you can't revert to it.
It is now a toggle
Yeah I thought about this. The tricky bit is it is more of a "revert commit" so there's no current way of distinguishing it. If we had a field to say something like "version this was copied from" that could be stored somewhere, at least in the activity log maybe 🤔 |
Ah, I was too slow :D A couple of nits, but not blocking so 🤷
|
Problem
We autosave changes which is great but sometimes you might make a change and think "whoops - I want to revert".
Undo redo works whilst the Notebook is open but after that you might want to revert to a previous version.
Changes
TODO
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?