feat: onboarding feature flags snippets #17638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelmsmith
requested review from
neilkakkar,
jurajmajerik,
liyiy and
ivanagas
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
only used by feature flags instructions so far
…ub.com/PostHog/posthog into feat/onboarding-feature-flags-snippets
|
Snapshot changes are definitely not desired.. will look into that Update: ✅ |
|
Here's the flow:
|
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
github-actions
bot
temporarily deployed
to
pr-feat/onboarding-feature-flags-snippets
github-actions
bot
temporarily deployed
to
pr-feat/onboarding-feature-flags-snippets
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
…ub.com/PostHog/posthog into feat/onboarding-feature-flags-snippets
github-actions
bot
temporarily deployed
to
pr-feat/onboarding-feature-flags-snippets
github-actions
bot
temporarily deployed
to
pr-feat/onboarding-feature-flags-snippets
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
github-actions
bot
temporarily deployed
to
pr-feat/onboarding-feature-flags-snippets
github-actions
bot
temporarily deployed
to
pr-feat/onboarding-feature-flags-snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We will very shortly have a dedicated onboarding flow for feature flags. We need to make sure anyone who wants to use feature flags has basically all the information they need to get up and running inside the app. The goal is to have every SDK/framework we support listed in the app.
Changes
I've set up a lot of the snippets already, thanks to the pre-existing feature flag snippets that are used on the feature flag create screen. I extended that component a bit so I could use it here.
Additionally, we offer a ton of docs, tutorials, etc on using other frameworks like gatsby, svelte, vue, etc that are not currently included here. I could use help getting those added here, maybe by @ivanagas? Or someone on the feature success team.
Update: I updated this PR to also use the shared snippets in the product analytics folder. Because those should be good to go, and the feature flag snippets are all based on the existing snippets in the app, all I basically need this team to review is what snippets are available in the feature_flags folder, and if others should be added, please do so 😄
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
🙈