chore: swap google_login key for social_sso #17634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelmsmith
commented
Sep 26, 2023
| @@ -859,7 +859,7 @@ def get_instance_available_sso_providers() -> Dict[str, bool]: | |||
| "SOCIAL_AUTH_GOOGLE_OAUTH2_SECRET", | |||
| None, | |||
| ): | |||
| if bypass_license or (license is not None and AvailableFeature.GOOGLE_LOGIN in license.available_features): | |||
| if bypass_license or (license is not None and AvailableFeature.SOCIAL_SSO in license.available_features): | |||
There was a problem hiding this comment.
This should only impact licensed self-hosted instances that aren't our cloud. I don't think we have any more of those? cc @simfish85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We offer more than just Google login as social SSO providers, so are changing the name to social_sso (and updating feature details https://github.com/PostHog/billing/pull/365).
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?