chore: Ignore {} unset value instead of DLQ the event #17633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
sometimes people send us
'$unset':{}<- we should just ignore it not DLQ the whole event. I made it so we just always take the keys if it's an object, so folks can also do'$unset':{'a':5}we send the events to DLQ, which is not what we want to be doing. DLQ helps us find bugs in our recent changes, but if it's always firing we can't use it for that.
DLQ: http://metabase-prod-us/question#eyJkYXRhc2V0X3F1ZXJ5Ijp7InR5cGUiOiJuYXRpdmUiLCJuYXRpdmUiOnsicXVlcnkiOiItLSBzZWxlY3QgdGVhbV9pZCwgY291bnQoKikgZnJvbSBldmVudHNfZGVhZF9sZXR0ZXJfcXVldWUgd2hlcmUgX3RpbWVzdGFtcCA-IHRvZGF5KCkgLSA1IGdyb3VwIGJ5IHRlYW1faWQgb3JkZXIgYnkgdGVhbV9pZFxuXG4tLSBzZWxlY3QgZXJyb3IsIGNvdW50KCopIGZyb20gZXZlbnRzX2RlYWRfbGV0dGVyX3F1ZXVlIHdoZXJlIF90aW1lc3RhbXAgPiB0b2RheSgpIGdyb3VwIGJ5IGVycm9yXG5cbnNlbGVjdCBlcnJvciwgKiBmcm9tIGV2ZW50c19kZWFkX2xldHRlcl9xdWV1ZSB3aGVyZSBfdGltZXN0YW1wID4gdG9kYXkoKSBsaW1pdCAyMCIsInRlbXBsYXRlLXRhZ3MiOnt9fSwiZGF0YWJhc2UiOjM2fSwiZGlzcGxheSI6InRhYmxlIiwiZGlzcGxheUlzTG9ja2VkIjp0cnVlLCJwYXJhbWV0ZXJzIjpbXSwidmlzdWFsaXphdGlvbl9zZXR0aW5ncyI6eyJ0YWJsZS5waXZvdF9jb2x1bW4iOiJjb3VudCgpIiwidGFibGUuY2VsbF9jb2x1bW4iOiJ0ZWFtX2lkIn0sIm9yaWdpbmFsX2NhcmRfaWQiOjI1OX0=
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?