Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys): add column with responses count #17623

Merged
merged 18 commits into from
Sep 27, 2023

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Sep 26, 2023

Problem

In the Surveys list view, users cannot see the number of responses for each survey.

Changes

Add a RESPONSES column to the list view, which displays the counts.

Screenshot 2023-09-26 at 11 05 43

How did you test this code?

UI: manually in the browser
API: wip

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! Few comments, and then just tests remain :)

frontend/src/scenes/surveys/surveysLogic.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/surveys/surveysLogic.tsx Outdated Show resolved Hide resolved
posthog/api/survey.py Outdated Show resolved Hide resolved
Copy link
Contributor

@liyiy liyiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @neilkakkar's comments are addressed

@jurajmajerik
Copy link
Contributor Author

Screen.Recording.2023-09-26.at.17.39.48.mov

This is what the cells look like when loading (hard to see on localhost - an intentional delay added here).

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

frontend/src/scenes/surveys/Surveys.tsx Show resolved Hide resolved
posthog/api/test/test_survey.py Outdated Show resolved Hide resolved
posthog/api/test/test_survey.py Outdated Show resolved Hide resolved
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@jurajmajerik jurajmajerik merged commit 02007d1 into master Sep 27, 2023
@jurajmajerik jurajmajerik deleted the surveys/response-count-column branch September 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants