Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace all Ant Popover with Lemon #17607

Merged
merged 5 commits into from
Sep 27, 2023
Merged

refactor: Replace all Ant Popover with Lemon #17607

merged 5 commits into from
Sep 27, 2023

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Sep 25, 2023

Changes

Prompted by #17532, this finally removes all the Ant Popover instances, replacing them with LemonDropdown. To this end, LemonDropdown now has a trigger="hover" option to satisfy all the existing use cases.

Before

Screenshot 2023-09-25 at 18 10 36

After

Screenshot 2023-09-25 at 18 08 20

@Twixes Twixes requested a review from benjackwhite September 25, 2023 16:12
@PostHog PostHog deleted a comment from posthog-bot Sep 25, 2023
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes merged commit 2832f97 into master Sep 27, 2023
72 checks passed
@Twixes Twixes deleted the hover-dropdown branch September 27, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants