feat: Batch export logs frontend #17605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
feat/batch-exports-logs-frontend
branch
from
ce61ea3 to
1a87007
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
@benjackwhite As usual, I value your input on frontend bits. But I don't want to take up much of your time, so feel free to skip this one if you are busy. Regardless, thank you! |
benjackwhite
approved these changes
Sep 26, 2023
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
tiina303
approved these changes
Sep 27, 2023
tomasfarias
force-pushed
the
feat/batch-exports-logs-frontend
branch
from
87c7655 to
469b3dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Frontend parts to display logs ingested in #17579. I mostly copied over the components used for pluginLogs and tried my best to adapt them for batch exports.
Changes
We now have tabs in batch exports UI, and logs look like this:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?