Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup plugins #17591

Merged
merged 7 commits into from
Oct 2, 2023
Merged

chore: cleanup plugins #17591

merged 7 commits into from
Oct 2, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Sep 22, 2023

Problem

Flag is enabled and not being turned off

Changes

  • Remove all the unused files
  • Remove the unused methods in the logic
  • Modernize CSS names
  • Removes a bunch of old antd and react-sortable-hoc

How did you test this code?

@daibhin
Copy link
Contributor Author

daibhin commented Sep 22, 2023

@benjackwhite you probably have much more context on this than I did. Hoping I didn't remove too much 😅

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REMOVED - This comment was for a different PR

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite self-requested a review September 25, 2023 08:22
@daibhin daibhin force-pushed the dn-chore/cleanup-plugins branch from da93015 to c78a85f Compare October 2, 2023 10:07
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin merged commit 0d29027 into master Oct 2, 2023
72 checks passed
@daibhin daibhin deleted the dn-chore/cleanup-plugins branch October 2, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants