Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace sortable-hoc on column configuration #17590

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Sep 22, 2023

Problem

We're migrating away from react-sortable-hoc

Changes

  • Removed the virtualized list. Do we ever need it? I can't imagine people create enough columns to warrant one and it makes the sorting much simpler
  • Removed a bunch of old styles

How did you test this code?

By 👁️

sorting.mp4

@daibhin
Copy link
Contributor Author

daibhin commented Sep 22, 2023

@Twixes @thmsobrmlr last one I swear 😂

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (bar the misaligned drag handle), definitely don't need that virtualization!

@@ -60,19 +47,3 @@
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need the 2px above to be centered, in fact the 2px makes things wonky

@Twixes Twixes force-pushed the dn/reordering-column-configuration branch from 672019e to 78f3f3a Compare September 25, 2023 15:37
@daibhin daibhin merged commit c0b8760 into master Oct 2, 2023
72 checks passed
@daibhin daibhin deleted the dn/reordering-column-configuration branch October 2, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants