Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improved instrumentation around core functions #17574

Merged
merged 8 commits into from
Sep 21, 2023
Merged

feat: Improved instrumentation around core functions #17574

merged 8 commits into from
Sep 21, 2023

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Sep 21, 2023 •
edited
Loading

Problem

We think there are some bottlenecks in prod but its unclear where they are. A few simple instrumentations would help to understand this

Changes

  • Downgrades some logs that we don't care about
  • Instrument the main ingestion loop.
  • Only stringifying the event if the timeout fires.
  • Lock on hostname instead of uuid so that we can identify which pod is the cause

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite requested a review from a team September 21, 2023 12:45
pauldambra
pauldambra approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@benjackwhite benjackwhite merged commit c7a797d into master Sep 21, 2023
@benjackwhite benjackwhite deleted the feat/blobby-instrumentation branch September 21, 2023 13:31
daibhin pushed a commit that referenced this pull request Sep 21, 2023
@benjackwhite @daibhin
feat: Improved instrumentation around core functions (#17574)
7ac4377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

@tiina303 tiina303 tiina303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjackwhite @tiina303 @pauldambra