Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop event if event type is snapshot (we have migrated to snapshot_items #17558

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

fuziontech
Copy link
Member

@fuziontech fuziontech commented Sep 20, 2023

Problem

We spend time at capture producing to Kafka on a topic that is deprecated. Let's not do that.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@PostHog PostHog deleted a comment from posthog-bot Sep 20, 2023
@pauldambra
Copy link
Member

We need to do this safely for self-hosted.

Aiming to do that this week if not for bugs and incidents 😅

@fuziontech fuziontech requested a review from frankh September 20, 2023 21:12
@fuziontech fuziontech merged commit 5870be2 into master Sep 20, 2023
@fuziontech fuziontech deleted the remove_old_path_session_recordings branch September 20, 2023 21:15
fuziontech added a commit that referenced this pull request Sep 20, 2023
fuziontech added a commit that referenced this pull request Sep 20, 2023
… to snapshot_items" (#17560)

Revert "chore: drop event if event type is snapshot (we have migrated to snapshot_items (#17558)"

This reverts commit 5870be2.
daibhin pushed a commit that referenced this pull request Sep 21, 2023
…shot_items (#17558)

* chore: drop event if event type is snapshot (we have migrated to snapshot_items

* Add a comment
daibhin pushed a commit that referenced this pull request Sep 21, 2023
… to snapshot_items" (#17560)

Revert "chore: drop event if event type is snapshot (we have migrated to snapshot_items (#17558)"

This reverts commit 5870be2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants