Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(recordings): Treat initial player state as aria-busy #17543

Closed
wants to merge 3 commits into from

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Sep 20, 2023

Changes

From the naming of the READY member of SessionPlayerState, I thought this meant the player is ready – but no, that means it's in its initial state and being made ready at that stage.
Clarifying that into INIT and treating that state as a busy state should prevent flakiness of player UI snapshots, such as this: #17532 (comment)

@Twixes Twixes requested a review from benjackwhite September 20, 2023 09:30
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I don't follow. The "Ready" state means "I have loaded my metadata and am ready to play but am not actively playing yet" - for example when it is in a notebook, we dont have autoplay on.

aria-busy is meant for loading states, which the "Ready" or "init" state is not.

@Twixes
Copy link
Member Author

Twixes commented Sep 20, 2023

Hmm, fair, this assumed that autoplay is always on. Unfortunately also clearly this does not solve the flakiness problem, because this commit is exactly the thing that shouldn't happen 😅 Can you add the correct waitForSelector to recordings stories in a separate PR to prevent this from happening? 🙏

@Twixes Twixes closed this Sep 20, 2023
@Twixes Twixes deleted the deterministic-player-stories branch June 13, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants