Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Recompute notebook title #17526

Merged
merged 16 commits into from
Sep 19, 2023
Merged

feat: Recompute notebook title #17526

merged 16 commits into from
Sep 19, 2023

Conversation

benjackwhite
Copy link
Contributor

Problem

Took over from #17508

Changes

  • Removes async updating of title (this would cause a lot of over-fetching - yuck.
  • Swaps for simple defaultTitle, with useEffect as the primary way for triggering title changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite requested a review from a team September 19, 2023 13:06
@benjackwhite benjackwhite mentioned this pull request Sep 19, 2023
Closed
daibhin
daibhin approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

frontend/src/scenes/notebooks/Nodes/NotebookNodeSurvey.tsx Show resolved Hide resolved
frontend/src/scenes/notebooks/Nodes/NodeWrapper.tsx Outdated Show resolved Hide resolved
@benjackwhite benjackwhite enabled auto-merge (squash) September 19, 2023 13:59
@benjackwhite benjackwhite merged commit b653af8 into master Sep 19, 2023
73 checks passed
@benjackwhite benjackwhite deleted the feat/recompute-notebook-title branch September 19, 2023 14:58
daibhin pushed a commit that referenced this pull request Sep 21, 2023
@benjackwhite @daibhin
feat: Recompute notebook title (#17526)
4484de8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

@pauldambra pauldambra pauldambra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjackwhite @pauldambra @daibhin