Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use cached insight result in SavedInsight #17510

Merged
merged 1 commit into from
Sep 19, 2023
Merged

feat: use cached insight result in SavedInsight #17510

merged 1 commit into from
Sep 19, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Sep 18, 2023

Problem

cachedResults was never passed into the query node, and by association the saved insight node.

Changes

  • Remove the cachedResults prop from SavedInsight
  • Pass the cachedResults from the insight through to the recursive call to Query

How did you test this code?

🙈

@daibhin daibhin merged commit ec67915 into master Sep 19, 2023
@daibhin daibhin deleted the dn-feat/cache-results branch September 19, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daibhin @benjackwhite