chore(plugin-server): Allow full rollout of hostname guard #17500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiina303
approved these changes
Sep 19, 2023
| @@ -362,7 +362,10 @@ export class HookCommander { | |||
| `⌛⌛⌛ Posting Webhook slow. Timeout warning after 5 sec! url=${webhookUrl} team_id=${team.id} event_id=${event.eventUuid}` | |||
| ) | |||
| }, 5000) | |||
| const relevantFetch = isCloud() && this.fetchHostnameGuardTeams.has(team.id) ? safeTrackedFetch : trackedFetch | |||
| const relevantFetch = | |||
| isCloud() && (!this.fetchHostnameGuardTeams || this.fetchHostnameGuardTeams.has(team.id)) | |||
There was a problem hiding this comment.
nit: I'd re-add the comment here about empty = enabled for everyone as that's hard to reason about otherwise
daibhin
pushed a commit
that referenced
this pull request
Sep 21, 2023
* chore(plugin-server): Allow full rollout of hostname guard * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #17183, adding
*as aFETCH_HOSTNAME_GUARD_TEAMSvalue meaning "roll out for all projects".