Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove OptiPNG from local dev #17490

Merged
merged 1 commit into from
Sep 18, 2023
Merged

chore: Remove OptiPNG from local dev #17490

merged 1 commit into from
Sep 18, 2023

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Sep 18, 2023

Problem

We use OptiPNG for compressing UI snapshots updated locally, but it's making merges very slow due to redundant optimization runs – and we practically don't update snapshots locally since CI takes care of that.

Changes

Getting rid of local OptiPNG. Leaving it in in CI.

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes merged commit 683512e into master Sep 18, 2023
@Twixes Twixes deleted the rm-optipng branch September 18, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants