feat: step towards feature folders for replay backend #17484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Sep 17, 2023
Comment on lines
+75
to
+76
| e, | ||
| extras={"attempt_count": attempt_count, "operation": "get_realtime_snapshots"}, |
pauldambra
commented
Sep 17, 2023
There was a problem hiding this comment.
mypy went to town in this file...
We should probably switch to operate entirely on lists or entirely on generators when we delete the old session recording code
pauldambra
commented
Sep 17, 2023
Comment on lines
+154
to
+158
| if isinstance(_events, Generator): | ||
| # we check the first item in the events below so need to be dealing with a list | ||
| events = list(_events) | ||
| else: | ||
| events = _events |
There was a problem hiding this comment.
we sometimes pass a generator into this function, and then check events[0] but generators aren't subscriptable... so mypy was very unhappy with us
benjackwhite
approved these changes
Sep 18, 2023
|
@fuziontech this doesn't change anything about the session recording/replay migrations, just moves them. I've checked I can nuke and recreate locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend files for replay are spread allover the place. We use feature folders in the front-end code. Let's step towards that for the backend by gathering the replay files in one place in posthog and ee