refactor: Format all BatchExports datetimes as isoformat #17468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
refactor/do-all-isoformatted-dates
branch
from
3afaae4 to
4bb6f72
Compare
tomasfarias
force-pushed
the
refactor/do-all-isoformatted-dates
branch
from
db19cfb to
04566c2
Compare
tomasfarias
changed the title
tiina303
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Not sure why we were not using
isoformat().Changes
Return isoformatted timestamps when iterating through CH rows. Technically, we were already returning isoformatted rows as the separator is not required. But the standard rfc 3399 requires a separator (
T).👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Tests will likely fail and I'll fix them up.